Feature to set ip resolver type in request options #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
============================================
- Coverage 92.12% 92.02% -0.10%
- Complexity 761 763 +2
============================================
Files 21 21
Lines 1764 1767 +3
============================================
+ Hits 1625 1626 +1
- Misses 139 141 +2
Continue to review full report at Codecov.
|
Member
|
@ShivamYuvraj Thank you for contributing. Would it be possible to add some unit tests for this change ? |
Collaborator
|
Any idea on how to implement a unit test that would not add yet another dependency on an external host? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.