Conversation
`report-to-issues` checks out live `trunk` rather than this branch before running `./packages/report-flaky-tests`, so it always executes against whatever that action looks like on trunk today instead of a fixed target. Trunk has since changed the action's shape twice, and the job's inputs no longer match it: the most recent run of this job on `wp/6.9` already logged `Unexpected input(s) 'label'`, and trunk's `action.yml` now accepts only `artifact-path` and a required `output-path` that this job never supplies. `repo-token` and `label` are both gone. The rewrite behind those changes is also a product-policy change, not a CI fix: flaky tests are now rendered into a pull request comment and are no longer filed as GitHub issues at all. Porting that to a frozen, security-maintenance-only branch is out of scope, so the job is removed instead. Doing so drops only an automated notification; no test pass/fail signal depends on it, and the flaky test artifacts are still collected and merged by the jobs above. The `has-flaky-test-report` output on `merge-artifacts` and the step `id` feeding it existed only to gate this job, so they are removed with it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtSAAJkQ9P6vPtDumqStg8
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #82877
September 21, 2026 18:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82785.
What?
Removes the
report-to-issuesjob from.github/workflows/end2end-test.yml, along with the two things that existed only to feed it: thehas-flaky-test-reportoutput onmerge-artifacts, and theid: merge-flaky-tests-reportson the step that output read from.Nothing else changes. The e2e jobs still archive their flaky test reports, and
merge-artifactsstill merges them into a downloadableflaky-tests-reportartifact.wp/6.9is the last branch still carrying this job; every other maintainedwp/X.Ybranch has already had it removed.Why?
The job checks out live
trunk— not this branch — and then runs./packages/report-flaky-testsfrom that checkout. It therefore always executes against whatever the action looks like on trunk today, rather than against a fixed, frozen target. That makes it a permanent source of drift on a frozen branch, and trunk has since moved twice:labelinput.repo-tokenas well and adding a requiredoutput-pathinput.The drift is already visible in this branch's own CI. The most recent run of this job on
wp/6.9(run 31178713984, 2026-08-07) logged:Since then trunk's
packages/report-flaky-tests/action.ymlhas narrowed further, to:So all three inputs this job passes are now wrong:
repo-tokenandlabelare both unexpected, and the requiredoutput-pathis never supplied. Trunk'ssrc/run.tsreads it withcore.getInput( 'output-path', { required: true } )after it has collected the flaky tests, andsrc/index.tsroutes a thrown error throughcore.setFailed(). Because the job only runs at all when a flaky test report exists, the next flaky test on this branch takes that path and fails the job outright.Even setting the hard failure aside, the job can no longer do the thing it is named for: trunk's action only renders markdown to a file now. It does not open
[Type] Flaky Testissues, which is the behavior this branch's workflow was written to invoke.Retrofitting trunk's current design was considered and rejected. It is not just a CI repair — it is a product-policy change (flaky tests become PR-comment-only and are never filed as issues) and it would pull a rewritten, type-stripped Node 24 action onto a frozen, security-maintenance-only branch. Removing the job drops only an automated notification; no test pass/fail signal depends on it, and the flaky test data is still published as an artifact.
packages/report-flaky-testsitself is left in place. After this change no workflow on this branch uses it, but removing the package is a separate, optional cleanup.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code
https://claude.ai/code/session_01DtSAAJkQ9P6vPtDumqStg8