Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Wscats/piano
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Wscats/piano
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: refactor-claude-opus
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 48 files changed
  • 3 contributors

Commits on Mar 30, 2026

  1. refactor(claude-opus): deep code-level refactoring

    Applied comprehensive refactoring based on wscats-projects-refactor-spec.md:
    
    - .editorconfig
    - .gitignore
    - .prettierrc
    - tsconfig.json
    - jest.config.js
    - .github/workflows/ci.yml
    - .github/dependabot.yml
    - src/utils/error-handling.ts
    - src/utils/security.ts
    - src/utils/performance.ts
    - src/utils/index.ts
    - src/utils/__tests__/error-handling.test.ts
    - src/utils/__tests__/security.test.ts
    - src/utils/__tests__/performance.test.ts
    - src/refactored/piano-player.ts
    - src/refactored/piano-player.test.ts
    - package.json
    - REFACTOR.md
    
    Key additions:
    - TypeScript utility modules (error-handling, security, performance)
    - Comprehensive test suite with 80% coverage threshold
    - Project-specific code refactoring
    - ESLint + Prettier + TypeScript strict mode
    - GitHub Actions CI/CD pipeline
    claude-opus-refactor authored and Wscats committed Mar 30, 2026
    Configuration menu
    Copy the full SHA
    c08d14f View commit details
    Browse the repository at this point in the history
  2. refactor: deep code modernization and quality improvements

    Changes:
    - .editorconfig
    - .gitignore
    - .prettierrc
    - .github/workflows/ci.yml
    - .github/dependabot.yml
    - LICENSE
    - CONTRIBUTING.md
    - removed .eslintrc
    - .eslintrc.json
    - tsconfig.json
    - jest.config.js
    - src/utils/security.ts
    - src/utils/error-handling.ts
    - src/utils/performance.ts
    - src/utils/index.ts
    - src/utils/__tests__/security.test.ts
    - src/utils/__tests__/error-handling.test.ts
    - src/utils/__tests__/performance.test.ts
    - 10 JS files modernized
    - package.json
    - REFACTOR.md
    
    Key improvements:
    - Modernized JS: var→const/let, ==→===, 'use strict'
    - Stricter ESLint & TypeScript configs
    - Added security, error-handling, performance utilities
    - 80% coverage threshold, Node 18/20/22 CI matrix
    - Added LICENSE, CONTRIBUTING.md
    refactor-bot authored and Wscats committed Mar 30, 2026
    Configuration menu
    Copy the full SHA
    59fef73 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2026

  1. refactor: clean up piano web component

    - Remove ~5 console.log from playNote, stopSong, playSong, handleString
    - Fix deprecated arguments.callee.caller usage
    - Add null check for missing notes in playNote
    - Remove dead createPianoKeys() function (~80 lines)
    - Remove commented-out CSS (user-select, transition, font-size)
    - Replace Chinese CSS comments with English
    refactor-bot authored and Wscats committed Mar 31, 2026
    Configuration menu
    Copy the full SHA
    249c874 View commit details
    Browse the repository at this point in the history
  2. refactor: complete JS to TypeScript migration

    - Convert all 15 JS source files to TypeScript
    - Create types.ts with full type definitions (NotesMap, PianoKeyPair, Song, etc.)
    - Create omi.d.ts with Omi framework type declarations
    - Add PianoData, FooterData interfaces for component data
    - Type PianoStore interface for state management
    - Extract KEY_CODE_TO_NOTE/KEY_CODE_TO_SHARP maps (replace 2 switch blocks)
    - Extract gradient constants (WHITE_KEY_BG, ACTIVE_KEY_BG, BLACK_KEY_BG)
    - Extract timing constants (KEY_HIGHLIGHT_DURATION, NOTE_COOLDOWN_DURATION)
    - Add JSDoc documentation to all public methods
    - Fix malformed test.ts (loose expressions → proper typed array)
    - Replace e.returnValue with e.preventDefault()
    - Remove vendor-prefixed CSS duplicates
    - Update tsconfig: allowJs=false, add jsx/jsxFactory config
    - Net reduction: 291 lines
    refactor-bot authored and Wscats committed Mar 31, 2026
    Configuration menu
    Copy the full SHA
    6b23642 View commit details
    Browse the repository at this point in the history
Loading