Skip to content

xfree86: silence warnings on SYSCALL() macro #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
metux merged 1 commit into from
Dec 11, 2025
Merged

xfree86: silence warnings on SYSCALL() macro #1632

metux merged 1 commit into from
Dec 11, 2025

Conversation

@metux
Copy link
Contributor

@metux metux commented Dec 11, 2025

../hw/xfree86/os-support/shared/posix_tty.c:366:38: warning: while loop has empty body [-Wempty-body]
366 | SYSCALL(r = read(fd, buf, count));
| ^

Signed-off-by: Enrico Weigelt, metux IT consult info@metux.net

@metux
xfree86: silence warnings on SYSCALL() macro
31c26a0 
> ../hw/xfree86/os-support/shared/posix_tty.c:366:38: warning: while loop has empty body [-Wempty-body]
>    366 |     SYSCALL(r = read(fd, buf, count));
>        |                                      ^

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
@metux metux self-assigned this Dec 11, 2025
metux added a commit that referenced this pull request Dec 11, 2025
@metux
[PR #1632] xfree86: silence warnings on SYSCALL() macro
f26e048 
PR: #1632
@stefan11111
Copy link
Contributor

stefan11111 commented Dec 11, 2025

@metux what compiler throws a warning on while(foo());?
This is the canonical way of writing such loops.

@metux
Copy link
Contributor Author

metux commented Dec 11, 2025

@metux what compiler throws a warning on while(foo());? This is the canonical way of writing such loops.

happening with clang on *BSD. Strangely only in a single case.

@metux metux merged commit c2d6007 into maint-25.0 Dec 11, 2025
@metux metux deleted the pr/xfree86-silence-warnings-on-syscall-macro-_2025-12-11_14-42-25 branch December 11, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikedld mikedld Awaiting requested review from mikedld

@jonhermansen jonhermansen Awaiting requested review from jonhermansen

@josephcrowell josephcrowell Awaiting requested review from josephcrowell

@cepelinas9000 cepelinas9000 Awaiting requested review from cepelinas9000

@algrid algrid Awaiting requested review from algrid

@callmetango callmetango Awaiting requested review from callmetango

@stefan11111 stefan11111 Awaiting requested review from stefan11111

@b-aaz b-aaz Awaiting requested review from b-aaz

@ONykyf ONykyf Awaiting requested review from ONykyf

Assignees

@metux metux

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@metux @stefan11111