Skip to content

Remove --device all from all commands #5236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maxzhen merged 2 commits into from
May 11, 2021
Merged

Remove --device all from all commands #5236

maxzhen merged 2 commits into from
May 11, 2021

Conversation

@AShivangi-zz
Copy link

@AShivangi-zz AShivangi-zz commented May 10, 2021 •
edited by rozumx
Loading

  • Removed support for -d all from all commands which supported multiple devices
  • Removed "all" from help menus
  • Testing for xbmgmt/xbutil examine:
xbmgmt/xbutil examine                        ----> host report
xbmgmt/xbutil examine -r host                ----> host report
xbmgmt/xbutil examine -r host -d 17:00 18:00 ----> host report
xbmgmt/xbutil examine -d 17:00 18:00         ----> ERROR
xbutil examine -d 17:00                      ----> platform and CU report
xbmgmt examine -d 17:00                      ----> platform

Sample output:

$ xbmgmt examine -d 17:00 18:00

ERROR: Examining multiple devices is not supported. Please specify a single device using --device option

List of available devices:
  [0000:65:00.0] : xilinx_u200_xdma_201830_2
  [0000:18:00.0] : xilinx_u30_gen3x4_base_1
  [0000:17:00.0] : xilinx_u30_gen3x4_base_1
  • CR-1098821

@AShivangi-zz AShivangi-zz requested a review from rozumx May 10, 2021 20:23
rozumx
rozumx approved these changes May 10, 2021
View reviewed changes
Copy link
Collaborator

@rozumx rozumx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thank you for the 1-on-1 code review earlier.

@gbuildx
Copy link
Collaborator

gbuildx commented May 11, 2021

Build Failed! :(

1 similar comment
@gbuildx
Copy link
Collaborator

gbuildx commented May 11, 2021

Build Failed! :(

@xilinxgitops
Copy link

xilinxgitops commented May 11, 2021

retest this please

@gbuildx
Copy link
Collaborator

gbuildx commented May 11, 2021

Build Passed!

@maxzhen maxzhen merged commit 41f6054 into Xilinx:u30 May 11, 2021
AShivangi-zz pushed a commit to AShivangi-zz/XRT that referenced this pull request May 19, 2021
@AShivangi
Remove --device all from all commands (Xilinx#5236)
77c96f2 
* remove -d all from all commands

* rm device all for reset
(cherry picked from commit 41f6054)
maxzhen pushed a commit that referenced this pull request May 25, 2021
@AShivangi
Remove --device all from all commands (#5236) (#5278)
2decf75 
* remove -d all from all commands

* rm device all for reset
(cherry picked from commit 41f6054)
@AShivangi-zz AShivangi-zz deleted the rm-all branch May 26, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rozumx rozumx rozumx approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AShivangi-zz @gbuildx @xilinxgitops @rozumx @maxzhen @AShivangi