AIESW-30957 Limit certain xrt-smi examine queries to proper reports#9816
AIESW-30957 Limit certain xrt-smi examine queries to proper reports#9816rchane wants to merge 5 commits into
Conversation
Signed-off-by: Ryan Chane <rchane@xilinx.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
aktondak
left a comment
There was a problem hiding this comment.
Instead of introducing a default parameter which might get difficult to maintain.
Let's instead introduce a new API on XBUtilities (maybe get_devices) which only does the getting devices part and skips filling up additional metadata. Then use that API wherever we want to get devices without filling any additional metadat.
We'll change less of existing code this way and will only make incremental changes
Signed-off-by: Ryan Chane <rchane@xilinx.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Ryan Chane <rchane@xilinx.com>
Signed-off-by: Ryan Chane <rchane@xilinx.com>
Signed-off-by: Ryan Chane <rchane@xilinx.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Let's confirm with @diukirde that the current minimal implementation is not as expensive as now we only request for device class from driver. |
This looks good to me. I will verify this once the PR is merged. |
Problem solved by the commit
https://jira.xilinx.com/browse/AIESW-30957
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Discovered during testing
How problem was solved, alternative solutions (if any) and why they were rejected
get_available_devices had these metadata queries included, such as FW version/CERT version, that were being called with every time. This change limits those queries to only be done for host report and --version, where they are needed.
Risks (if any) associated the changes in the commit
N/A
What has been tested and how, request additional testing if necessary
Tested on GPT
Documentation impact (if any)
N/A