Skip to content

Conversation

@axunonb
Copy link
Member

@axunonb axunonb commented Apr 19, 2021

No description provided.

@axunonb axunonb requested a review from NKnusperer April 19, 2021 12:36
@axunonb axunonb changed the title ICustomSerializer never used, but public (breaking change) ICustomDeserializer never used, but public (breaking change) Apr 19, 2021
@304NotModified
Copy link
Collaborator

Strange it isn't used!

@axunonb
Copy link
Member Author

axunonb commented Apr 19, 2021

Strange it isn't used!

Yes, I couldn't believe as well. Sometime the interface would have simplified customer serializers, but it's not that important.

@304NotModified
Copy link
Collaborator

Maybe also a good idea to clean the regions?
https://github.com/YAXLib/YAXLib/search?q=ICustomDeserializer&type=

@pull-request-size pull-request-size bot added size/M and removed size/S labels Apr 22, 2021
Copy link
Collaborator

@304NotModified 304NotModified left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@axunonb axunonb merged commit be0c218 into YAXLib:master Apr 23, 2021
@axunonb axunonb deleted the Remove_ICustomDeserializer branch April 23, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants