Skip to content

Conversation

@axunonb
Copy link
Member

@axunonb axunonb commented Aug 18, 2021

The UdtWrapper now initializes the UnderlyingType property with the underlying type of the udtType, if it is nullable.

Corrected unit tests in YAXLibTests/SerializationTest.cs:

  • NullableSample2Test()
  • NullableSample2WithNullAttributeTest()

Added De/Serialilzation test for fields.

@axunonb axunonb requested a review from 304NotModified August 18, 2021 22:58
@axunonb axunonb added this to the v3.0.1 milestone Aug 18, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2021

Codecov Report

Merging #161 (a41cd1a) into master (3188378) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #161   +/-   ##
=====================================
  Coverage      79%    80%           
=====================================
  Files          60     60           
  Lines        3764   3767    +3     
  Branches      724    726    +2     
=====================================
+ Hits         2988   2997    +9     
+ Misses        562    559    -3     
+ Partials      214    211    -3     
Impacted Files Coverage Δ
YAXLib/MemberWrapper.cs 81% <100%> (+2%) ⬆️
YAXLib/UdtWrapper.cs 82% <100%> (-<1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3188378...a41cd1a. Read the comment docs.

@axunonb axunonb linked an issue Aug 18, 2021 that may be closed by this pull request
Copy link
Collaborator

@304NotModified 304NotModified left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@axunonb axunonb merged commit 438a1ae into YAXLib:master Aug 19, 2021
@axunonb axunonb deleted the fix-handling-nullable-enums branch August 19, 2021 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nullable Enum won't serialize YaxEnum alias

3 participants