Set SPARK_DRIVER_TYPE for spark-run Spark drivers #4140
Merged
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemacysts
reviewed
Oct 30, 2025
paasta_tools/cli/cmds/spark_run.py
Outdated
Comment on lines
1438
to
1457
| # Prepare configuration required for some of the services | ||
| scs_args = { | ||
| "cluster_manager": args.cluster_manager, | ||
| "spark_app_base_name": app_base_name, | ||
| "docker_image": docker_image_digest, | ||
| "user_spark_opts": user_spark_opts, | ||
| "paasta_cluster": paasta_cluster, | ||
| "paasta_pool": args.pool, | ||
| "paasta_service": args.service, | ||
| "paasta_instance": paasta_instance, | ||
| "extra_volumes": cast(List[Mapping[str, str]], volumes), | ||
| "force_spark_resource_configs": args.force_spark_resource_configs, | ||
| "k8s_server_address": k8s_server_address, | ||
| "jira_ticket": args.jira_ticket, | ||
| "service_account_name": service_account_name, | ||
| "ui_port": int(spark_conf["spark.ui.port"]), | ||
| "user": os.environ.get("USER"), | ||
| "aws_account_id": get_aws_account_id(aws_creds), | ||
| } | ||
| args.scs = json.dumps(scs_args, indent=4) |
Member
There was a problem hiding this comment.
since we stuff this into spark_conf later - should we try to do this in spark_conf_builder.get_spark_conf() instead?
Contributor
Author
There was a problem hiding this comment.
good idea, will take a look and see which is better
Contributor
Author
There was a problem hiding this comment.
moved this code to spark_conf_builder.get_spark_conf()
Contributor
Author
There was a problem hiding this comment.
nemacysts
reviewed
Nov 11, 2025
Member
nemacysts
left a comment
There was a problem hiding this comment.
looks like a test is failing since we need to update it to account for this new env var - but lgtm otherwise
Contributor
Author
Thanks, i am fixing the tests |
… github.com:Yelp/paasta into timma/pass_config_required_for_some_of_the_services
nemacysts
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code required to pass configs required for some of the services