hash:feature - new hash format and handle the future depreciations#996
Merged
Conversation
aae8b0d to
e0944dc
Compare
Contributor
Author
|
Depends on: ZupIT/horusec-devkit#159 |
e0944dc to
3d92cba
Compare
matheusalcantarazup
suggested changes
Feb 24, 2022
3d92cba to
4d411ef
Compare
4d411ef to
fb39852
Compare
wiliansilvazup
approved these changes
Feb 24, 2022
matheusalcantarazup
suggested changes
Feb 25, 2022
Contributor
matheusalcantarazup
left a comment
There was a problem hiding this comment.
Its not clear to me why these changes in some formatters are necessary.
Currently cli generates very volatile hashes, any commit, description changes will change the hash, wich is a problem to the vulnerabilities management. This pull request changes the way that we generate the hash to use only the code, line and file, this way we expect that the hash will be more estable. In this pull request we also added a tratative to handle with the future depreciation of the old hashes that we still consider valid. So all users should update the oldated hashes, the cli is going to show a warning with the necessary hashes to update and the new ones. Signed-off-by: Nathan Martins <nathan.martins@zup.com.br>
fb39852 to
e941361
Compare
matheusalcantarazup
approved these changes
Feb 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently cli generates very volatile hashes, any commit, description
changes will change the hash, wich is a problem to the vulnerabilities
management. This pull request changes the way that we generate the hash
to use only the code, line and file, this way we expect that the hash
will be more estable. In this pull request we also added a tratative to
handle with the future depreciation of the old hashes that we still
consider valid. So all users should update the oldated hashes, the cli
is going to show a warning with the necessary hashes to update and the
new ones.
Signed-off-by: Nathan Martins nathan.martins@zup.com.br
- What I did
- How to verify it
- Description for the changelog