Fix #208: [BUG] no matching package named cidre found
#217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ound This commit fixes the issue where Linux/Windows users encounter an error when building the project due to the cidre dependency using an unstable Rust edition (2024) that requires nightly Cargo features. Root Cause: The cidre dependency was pointing to revision a9587fa which uses edition = "2024". This edition requires the unstable edition2024 Cargo feature, causing the build to fail on stable Rust with the error: 'no matching package named cidre found' Changes: 1. Updated cidre git revision from 'a9587fa' to 'efb9e060' - This revision uses edition = "2021" which is stable - Maintains all required features including 'av' for Core Audio support 2. Made cidre dependency optional to prevent unnecessary resolution on non-macOS platforms 3. Added documentation comment explaining the optional dependency The cidre dependency is now only resolved when building for macOS, and uses a stable Rust edition that works with stable Cargo versions. Linux/Windows users will no longer encounter the build error. Tested on Ubuntu 24.04 with Cargo 1.83.0 - dependency resolution succeeds without errors. Fixes Zackriya-Solutions#208 Co-Authored-By: Vedant Khanna <vedantkhanna@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #208
Summary
This PR fixes the issue where Linux/Windows users encounter an error when building the project due to the cidre dependency using an unstable Rust edition (2024) that requires nightly Cargo features.
Root Cause
The cidre dependency was pointing to revision
a9587fawhich usesedition = "2024". This edition requires the unstableedition2024Cargo feature, causing the build to fail on stable Rust with the error: 'no matching package named cidre found'Changes
edition = "2021"which is stableTesting
Tested on Ubuntu 24.04 with Cargo 1.83.0 - dependency resolution succeeds without errors.
The cidre dependency is now only resolved when building for macOS, and uses a stable Rust edition that works with stable Cargo versions. Linux/Windows users will no longer encounter the build error.
Files Modified
frontend/src-tauri/Cargo.tomlLink to Devin run: https://app.devin.ai/sessions/890dc2f9d6a8401eaaae0391d8ded3fe
Requested by: Vedant Khanna (vedantkhanna@gmail.com) (@VedantKh)
Analysis session: devin-fa0e934857644bda85fd86a984b52323