This repository was archived by the owner on Aug 27, 2025. It is now read-only.
Upgrade to Ocaml 4.10 and Core 0.14 (remove OCaml 4.07)#878
Merged
Conversation
added 3 commits
August 3, 2020 11:51
Fix compilation errors and warnings mostly resulting from the Core upgrade Disable OCaml 4.07 because the new version of Core is not compatible with it, hence we are free to use the new features provided by 4.08 (no new feature is used as of now)
Recently Core_kernel switched to Int.Replace_polymorphic_compare switched on by default (open Core_kernel already has this effect) The command I used to deal with the most of changes (GNU sed version, gsed): find ./src ./tests -type f -iname '*.ml' -print0 | xargs -0 gsed -i '/^open! Int.Replace_polymorphic_compare/d'
jjcnn
approved these changes
Aug 3, 2020
jjcnn
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
I've run make and make test using OCaml v4.08.1, and everything seems to check out.
vaivaswatha
pushed a commit
to Zilliqa/scilla-compiler
that referenced
this pull request
Aug 3, 2020
vaivaswatha
added a commit
to Zilliqa/scilla-compiler
that referenced
this pull request
Aug 3, 2020
* Upgrade to Ocaml 4.10 and Core 0.14 (remove OCaml 4.07) See Zilliqa/scilla#878 * Fix typo in compiler version 4.10.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable OCaml 4.07 because the new version of Core is not compatible
with it, hence we are free to use the new features provided by
4.08 (no new feature is used as of now).