Skip to content
This repository was archived by the owner on Aug 27, 2025. It is now read-only.

IPC test output types should be taken from the IPC state, not from th…#903

Merged
jjcnn merged 1 commit into
masterfrom
test_ipc_output_types_taken_from_ipc_client
Nov 10, 2020
Merged

IPC test output types should be taken from the IPC state, not from th…#903
jjcnn merged 1 commit into
masterfrom
test_ipc_output_types_taken_from_ipc_client

Conversation

@jjcnn

@jjcnn jjcnn commented Nov 10, 2020

Copy link
Copy Markdown
Contributor

…e gold state

@vaivaswatha

vaivaswatha commented Nov 10, 2020

Copy link
Copy Markdown
Contributor

Rather than switching gold with output, shouldn't we parse the output type too and assert that it's equivalent to gold type?

@vaivaswatha

vaivaswatha commented Nov 10, 2020

Copy link
Copy Markdown
Contributor

Rather than switching gold with output, shouldn't we parse the output type too and assert that it's equivalent to gold type?

Jacob's offline reply: it will be caught anyway in the output diff and easier to diagnose then.

@jjcnn jjcnn merged commit 97b38ca into master Nov 10, 2020
@jjcnn jjcnn deleted the test_ipc_output_types_taken_from_ipc_client branch November 10, 2020 03:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@anton-trunov anton-trunov Awaiting requested review from anton-trunov

1 more reviewer

@vaivaswatha vaivaswatha vaivaswatha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jjcnn @vaivaswatha