Skip to content

Remove nanos and update tokens #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abenso merged 2 commits into from
Oct 3, 2025
Merged

Remove nanos and update tokens #312

abenso merged 2 commits into from
Oct 3, 2025

Conversation

@abenso
Copy link
Collaborator

@abenso abenso commented Oct 3, 2025 •
edited by zboto bot
Loading

🔗 zboto Link

abenso added 2 commits October 3, 2025 12:32
@abenso
Remove nanos support (#310)
0de6ebf 
* remove nanos support

* bump version
@abenso
Add new tokens (#311)
1b6af9a
@gemini-code-assist
Copy link

gemini-code-assist bot commented Oct 3, 2025

Summary of Changes

Hello @abenso, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the project by deprecating support for the Ledger Nano S device, removing its specific build configurations and conditional code paths. It also expands the application's functionality by adding several new tokens to the registry and includes a minor version bump, alongside general code cleanup for protobuf initialization macros.

Highlights

  • Ledger Nano S Deprecation: Support for the Ledger Nano S device has been officially removed from the project, with corresponding build configurations, conditional compilation, and documentation updated to reflect this change.
  • Token Registry Update: Several new tokens, including cICP, sGLDT, EXE, PARTY, CLOUD, BOB, and ALEX, have been added to the application's token registry.
  • Version Increment: The application's patch version has been incremented from 1 to 2.
  • Codebase Refinement: Various protobuf initialization macros have been made more compact, and Nano S-specific display string adjustments have been removed, standardizing the UI text across supported devices.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/main.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 3, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily focuses on removing support for the Ledger Nano S device and updating the list of supported tokens. The changes are consistent across Makefiles, C source code, and documentation. I've identified one potential issue in the root Makefile where a build flag for Ledger Stax might have been unintentionally removed. The rest of the changes, including stylistic updates to protobuf header files, appear to be correct.

@abenso abenso merged commit e2c7b41 into main Oct 3, 2025
81 checks passed
@abenso abenso deleted the dev branch October 3, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xPxt 0xPxt 0xPxt approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abenso @0xPxt