fix k8s storage urls#838
Merged
Merged
Conversation
|
|
331e63a to
21e46d5
Compare
Codecov Report
@@ Coverage Diff @@
## master #838 +/- ##
==========================================
+ Coverage 78.44% 78.46% +0.01%
==========================================
Files 369 369
Lines 31938 31938
==========================================
+ Hits 25055 25060 +5
+ Misses 5185 5181 -4
+ Partials 1698 1697 -1
Continue to review full report at Codecov.
|
Collaborator
|
Thanks a lot for catching this, hopefully at some point we can find a way of writing an integration test to avoid this guide regressing in the future. Appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the k8s storage urls in the docs.