Skip to content

Make it a WebExtension (for Firefox Quantum+ compatibility) #70

Description

@chesterbr

Hello!

Love your extension/add-on on GMail, thank you for the hard work!

I recently switched back from Chrome to Firefox, and realized it could not be installed there:

2018-06-29_10-07-42

It seems Firefox Quantum (57+) only allows "WebExtensions". I have no idea of the work involved into making this a WebExtension, but I'm opening the issue, just in case someone would like to try.

Thank you!

Activity

  1. muan commented on Jun 29, 2018

    @muan
    Owner

    I checked to see how hard it is and looks like it's not trivial: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Porting_a_legacy_Firefox_add-on.

    I was so sure that the original firefox extension setup was a PR and not set up by me but git blame said I did it. 🙈 The code looks foreign to me now.

    Since I'm not a firefox user, I'd really appreciate if someone take this on! It's also pretty behind now: #36 #53.

  2. josephj11 commented on Nov 7, 2018

    @josephj11

    I am just starting to play around with Waterfox - a fork of Firefox before Quantum broke everything. Maybe your extension could be made to work there with less effort.
    I just tried to install it there, but the install button was disabled for some reason.

    I just installed the chrome version on Vivaldi. It's exactly what I was looking for! Thanks.

  3. Amazing-Amanda commented on Jul 28, 2019

    @Amazing-Amanda

  4. Coding-Hen commented on Aug 28, 2019

    @Coding-Hen

    Has anyone tried porting the chrome extension across rather than changing the original Firefox? Firefox has made it much easier now to port from Chrome with many of the extensions apis similar.

  5. mi11y commented on Oct 6, 2019

    @mi11y

    The Chrome extension seems to be made with WebExtensions. I loaded the chrome version of the plugin into firefox 69.0.2, and heres whats working and what is not:

    • The list view shortcut looks like its working. Clicking on it takes me to the issue.

    image

    • Mail view shortcut and mute thread are missing

    image

    Loading it into firefox gave the following warning:

    Reading manifest: Error processing options_page: An unexpected property was found in the WebExtension manifest.
    

    I could give porting this over to firefox a shot!

  6. mi11y commented on Oct 7, 2019

    @mi11y

    Heres what I got so far from porting over the chrome version of the extension: mi11y@51300a6

    The keyboard shortcuts dont work yet (ctrl + enter works). Everything else seems to be working!

  7. muan commented on Oct 28, 2019

    @muan
    Owner

    With 5bce1c9 this should work now.

    I've submit the updated version to Firefox Add-ons for a review, we'll see how that goes. In the mean time, loading the /firefox folder from about:debugging#/runtime/this-firefox should work.

    Shortcuts can be managed in Extensions -> Gear icon -> Manage Extension Shortcuts.

    image

    image

  8. muan commented on Oct 28, 2019

    @muan
    Owner

    Also thanks y’all for the discussion. Turns out it was indeed very easy porting it from the Chrome version which is already a webextension. I finally took this up because I’m trying to switch to Firefox. :) Most changes were deprecated methods. Switching to the standardized commands saved a ton of code. 👍

  9. muan commented on Nov 4, 2019

    @muan
    Owner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions