Skip to content

[popups] Fix touch openMethod when tapping outside element bounds on Safari #3541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
atomiks wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[popups] Fix touch openMethod when tapping outside element bounds on Safari #3541

atomiks wants to merge 1 commit into from

Conversation

@atomiks
Copy link
Contributor

@atomiks atomiks commented Dec 14, 2025

  • For Dialog, Menu, Popover, Combobox, and Autocomplete, this fixes openType not being "touch" in initialFocus when tapping outside an element's bounds but inside the hitslop area
  • For Select, this fixes alignItemWithTrigger not being deactivated on touch when tapping outside the trigger's bounds but inside the hitslop area

@atomiks atomiks added type: bug It doesn't behave as expected. browser: Safari Affects or fixes behavior in Apple Safari. mobile Targets mobile platform. scope: all components Widespread work has an impact on almost all components. labels Dec 14, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 14, 2025 •
edited
Loading

  • vite-css-base-ui-example

    pnpm add https://pkg.pr.new/mui/base-ui/@base-ui/react@3541

    pnpm add https://pkg.pr.new/mui/base-ui/@base-ui/utils@3541

commit: 41c246e

@mui-bot
Copy link

mui-bot commented Dec 14, 2025 •
edited
Loading

Bundle size report

Bundle Parsed size Gzip size
@base-ui/react 🔺+305B(+0.07%) 🔺+84B(+0.06%)

Details of bundle changes

Check out the code infra dashboard for more information about this PR.

@netlify
Copy link

netlify bot commented Dec 14, 2025 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 41c246e
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/693e8f51631f0a00083678fd
😎 Deploy Preview https://deploy-preview-3541--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@atomiks atomiks force-pushed the fix/safari-hitslop-open-method branch from 159b585 to 41c246e Compare December 14, 2025 10:19
@atomiks atomiks marked this pull request as ready for review December 14, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

browser: Safari Affects or fixes behavior in Apple Safari. mobile Targets mobile platform. scope: all components Widespread work has an impact on almost all components. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@atomiks @mui-bot