Feature/topcharge #265
Merged
Feature/topcharge #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides "ext_topologicalchargelattice" extension that computes the topological charge using a lattice-based formalism, rather than the discretisation of the continuum form.
Re-introduced cell volumes to obtain true density for the topological charge. Comparable to output from ext_topologicalcharge
Convex corners are now treaded correctly in topologicalchargelattice. topologicalchargefinitelattice is now redundant, and hence removed.
Contributor
|
@JeroenMulkers How does it score accuracy-wise in tests? |
Collaborator
Author
|
It gives exactly the same results as Joo-Von's implementation in the unit tests. These unit tests have a trivial geometry, in which case both implementations are equivalent, and hence we expect that it yields the same results The only thing which is different here, is that the contribution of a triangle is counted twice in a convex corner of the geometry. |
Contributor
|
@JeroenMulkers Good. Please give credit to the Joo-Von in the sources and make sure we ask to cite his paper if feature is used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative for the
topologicalchargelatticeimplementation proposed in pull request #262.The local topological charge is computed by taking a weighted sum of the topological charge contributions of the four elementary triangles defined by the four nearest neighbours.
In general, the elementary triangles of neighbouring cells overlap, in which case the charge contributions are counted twice. This is solved by using a weight of 1/2. (Exactly the same is done in the topologicalchargelattice implementation in #262)
However, the triangle at a convex corner of the geometry does not overlap any other triangles. Hence, at convex corners we use a weight of 1.