Add CPU info on Windows #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous
feature_logbranch (merged in commit e07e134) only retrieved CPU info for Linux.This PR adds CPU info for Windows systems. This does, however, require an external dependency to get keys from the Windows Registry. I am not sure if this is desirable, so I leave this as a Pull Request for now. Thoughts @JLeliaert?
Also, the command
mumax3 -testpreviously printed the GPU info, but since the new log prints the GPU info regardless, I have removed this now superfluous print statement frommumax3 -test.