Fix two-stage weight update server lookup#10
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: XU Mingshi <mxuax@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
python3 -m unittest tests.test_two_stage_vllm_rolloutBug and impact
The recent pre-weight-update abort path called a nonexistent
_get_server_name_prefix()onTwoStagevLLMRollout. On rank 0, the firstupdate_weights()call would crash before syncing rollout weights, interrupting training at the first weight update.