Fix beam search width collapse on early completions#20
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: XU Mingshi <mxuax@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
When some beam-search candidates reached EOS before
max_tokenswhile other active beams were still valid, the backend discarded all remaining active beams becausecompletedwas non-empty. The cache then contained fewer responses than the requested beam width, so later beam indices repeated the same completed candidate and effective beam width collapsed for constrained/two-stage rollout evaluation and training.Root cause
The recent duplicate-avoidance logic only preserved active beams when no candidate had completed at all, instead of preserving active beams whenever completed candidates did not fill
beam_width.Fix
Fill the remaining beam slots with active length-finished beams until
beam_widthis reached, while still avoiding active-beam duplicates once completed beams already cover the requested width.Validation
max_tokens.python3 -m py_compile verl_gr/workers/rollout/beam_backend.py tests/test_minionerec_parity.py.Note:
python3 -m pytest tests/test_minionerec_parity.pycould not run in this environment becausepytestis not installed.