Skip to content

Conversation

@colin-nolan
Copy link
Contributor

  • Catit branded pet feeder was not previously matching due to model missing a non-optional dps.
  • Adds additional sensors seen on Catit feeder.

@github-project-automation github-project-automation bot moved this to 👀 In review in Tuya Local Oct 26, 2025
- entity: sensor
icon: "mdi:paw"
name: Feed report
name: Last meal size
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming entities after release causes problems for existing users, who may have automations referencing this.

- id: 15
name: sensor
type: integer
range:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Range is not necessary for a sensor.

max: 12
# Only present after feeding on Catit 43752
optional: true
readonly: true
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readonly is implied by the fact the entity is a sensor, so adding this is not necessary.

icon: "mdi:paw"
name: Manual feed
category: config
name: Feed meal
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming after release causes problems

- dps_val: 2
value: true
- value: false
readonly: true
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readonly is implied by the fact this is a binary_sensor

- dps_val: 4
value: true
- value: false
readonly: true
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implied

- entity renaming causes issues for existing users
- readonly is not necessary to add on sensors
- some tweaks to product details
@colin-nolan
Copy link
Contributor Author

colin-nolan commented Oct 27, 2025

@make-all Many thanks for reviewing, and making necessary changes.

I did wonder whether the name changes were backwards compatible. I reasoned that the config was probably only used on setup, and hence wouldn't break existing (i.e. sensors setup with an older version would maintain their existing IDs). Sounds like I was wrong there - apologies for that. My motivation was to make the names a little more accurate.

@make-all make-all merged commit a5b44b0 into make-all:main Oct 27, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Tuya Local Oct 27, 2025
make-all added a commit that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants