Skip to content

Fixed: wp version issue for some host #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thanghv merged 4 commits into from
Apr 22, 2025
Merged

Fixed: wp version issue for some host #456

thanghv merged 4 commits into from
Apr 22, 2025

Conversation

@thanghv
Copy link
Contributor

@thanghv thanghv commented Apr 17, 2025 •
edited by coderabbitai bot
Loading

All Submissions:

Changes proposed in this Pull Request:

Closes # .

How to test the changes in this Pull Request:

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

Summary by CodeRabbit

  • Refactor
    • Improved how the WordPress version is retrieved throughout the application for greater reliability and consistency.
    • Updated timestamp recording for site changes to use the native time function, resolving timezone display issues.
  • New Features
    • Enhanced compatibility by using a more robust method to detect the WordPress version, ensuring support for newer WordPress functions when available.

@coderabbitai
Copy link

coderabbitai bot commented Apr 17, 2025 •
edited
Loading

Walkthrough

The changes systematically replace all direct usages of the global $wp_version variable across multiple classes with a standardized call to MainWP_Child_Server_Information_Base::get_wordpress_version(). This involves updating internal logic, status messages, API requests, and version comparisons to use the new method. Additionally, the visibility of get_wordpress_version() is changed from protected to public, and it now checks for the existence of the \wp_get_wp_version() function before falling back to the global variable. The timestamp for site changes events is changed to use the native PHP time() function instead of a custom helper method. No public method signatures are altered, and the overall control flow remains the same.

Changes

File(s) Change Summary
class/class-mainwp-child-actions.php
class/class-mainwp-child-back-up-buddy.php
class/class-mainwp-child-plugins-check.php
class/class-mainwp-child-stats.php
class/class-mainwp-child-updates.php
class/class-mainwp-child-updraft-plus-backups.php
class/class-mainwp-child-vulnerability-checker.php
class/class-mainwp-child-wordfence.php
class/class-mainwp-clone.php		 Replaced all usage of the global $wp_version variable with calls to MainWP_Child_Server_Information_Base::get_wordpress_version() across various methods. Updated internal logic, API calls, version comparisons, and status messages accordingly. Also replaced a custom timestamp method with PHP native time() in site changes. No changes to public method signatures.
class/class-mainwp-child-server-information-base.php Changed get_wordpress_version() from protected to public static. Enhanced the method to check for the existence of \wp_get_wp_version() and use it if available; otherwise, it falls back to the global $wp_version.
class/class-mainwp-child.php
mainwp-child.php
readme.txt		 Updated the plugin version from 5.4.0.5 to 5.4.0.6 in the main class, plugin header, and changelog. The changelog notes the switch to native time() for timestamps and improved WordPress version retrieval method.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant MainWP_Child_Server_Information_Base
    participant WordPressCore

    Caller->>MainWP_Child_Server_Information_Base: get_wordpress_version()
    alt wp_get_wp_version exists
        MainWP_Child_Server_Information_Base->>WordPressCore: wp_get_wp_version()
        WordPressCore-->>MainWP_Child_Server_Information_Base: version string
        MainWP_Child_Server_Information_Base-->>Caller: version string
    else
        MainWP_Child_Server_Information_Base->>WordPressCore: access $wp_version global
        WordPressCore-->>MainWP_Child_Server_Information_Base: version string
        MainWP_Child_Server_Information_Base-->>Caller: version string
    end
Loading
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6c25d14 and 9275230.

📒 Files selected for processing (3)
  • class/class-mainwp-child.php (1 hunks)
  • mainwp-child.php (1 hunks)
  • readme.txt (2 hunks)
✅ Files skipped from review due to trivial changes (3)
  • mainwp-child.php
  • readme.txt
  • class/class-mainwp-child.php
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Codacy Static Code Analysis
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@marcusquinn marcusquinn mentioned this pull request Apr 19, 2025
Open
6 tasks
@marcusquinn
Copy link

marcusquinn commented Apr 19, 2025 •
edited
Loading

checks now passed in #461

this PR can be closed

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 22, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@thanghv thanghv merged commit 0b2b807 into master Apr 22, 2025
3 of 4 checks passed
@thanghv thanghv deleted the mainwp-child-dev-5.4.0.6 branch April 24, 2025 05:54
@coderabbitai coderabbitai bot mentioned this pull request Jun 18, 2025
Closed
6 tasks
This was referenced Aug 13, 2025
Open
Merged
This was referenced Nov 18, 2025
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thanghv @marcusquinn @code-factor