Linter: Fix --version flag for CLI
#488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoroth
reviewed
Sep 9, 2025
Owner
marcoroth
left a comment
There was a problem hiding this comment.
Hey @drewhoffer, thanks for opening this pull request!
I was about to merge this, when I realized we have very similar code here already:
herb/javascript/packages/linter/src/cli/argument-parser.ts
Lines 75 to 79 in 70cd74f
Would you mind porting that over there? Thank you!
--version flag for CLI
asilano
pushed a commit
to fac/herb
that referenced
this pull request
Oct 21, 2025
Closes marcoroth#437 --------- Co-authored-by: Marco Roth <marco.roth@intergga.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check first if the user just wants to see the version of their linter. If so, print and exit.
Closes #437