Linter: Implement erb-comment-syntax linter rule
#528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5977ba to
bcf284f
Compare
bcf284f to
47a6ac3
Compare
erb-comment-syntax linter rule
marcoroth
approved these changes
Sep 30, 2025
Owner
marcoroth
left a comment
There was a problem hiding this comment.
Thanks for implementing this @domingo2000! 🙏🏼
asilano
pushed a commit
to fac/herb
that referenced
this pull request
Oct 21, 2025
Closes: marcoroth#527 Advances: marcoroth#537 This PR adds the rule `erb-comment-syntax`. It is the same rule implemented in [CommentSyntax](https://github.com/Shopify/erb_lint?tab=readme-ov-file#commentsyntax) of ERB Lint. The rule itself avoid parsing errors in the action_view erb default parsing implementation. Also the porting of ERB Lint rules to herb rules facilitates the adoption of Herb as a ERB Lint replacement. --------- Co-authored-by: Marco Roth <marco.roth@intergga.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #527
Advances: #537
This PR adds the rule
erb-comment-syntax. It is the same rule implemented in CommentSyntax of ERB Lint.The rule itself avoid parsing errors in the action_view erb default parsing implementation.
Also the porting of ERB Lint rules to herb rules facilitates the adoption of Herb as a ERB Lint replacement.