C: Use hb_string_T in herb_analyze function
#678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2f848e to
49dce47
Compare
hb_string in herb_analyze functionhb_string_T in herb_analyze function
marcoroth
reviewed
Oct 18, 2025
|
|
||
| if (strcmp(opening, "<%%") != 0 && strcmp(opening, "<%%=") != 0 && strcmp(opening, "<%#") != 0) { | ||
| analyzed_ruby_T* analyzed = herb_analyze_ruby(erb_content_node->content->value); | ||
| analyzed_ruby_T* analyzed = herb_analyze_ruby(hb_string_from_c_string(erb_content_node->content->value)); |
Owner
There was a problem hiding this comment.
I wonder, if we eventually should change the StringField in template.rb to just be a hb_string_T on all AST Nodes, so we don't have to always convert them when using them.
Contributor
Author
There was a problem hiding this comment.
Long term that's definitely the plan.
I just try to get there in small steps so that we won't have a giant PR that is hard to test, ideally we can always easily check for regressions.
asilano
pushed a commit
to fac/herb
that referenced
this pull request
Oct 21, 2025
This PR starts using the `hb_string_T` in the interface of `herb_analyze`. This is a side effect free refactor, that makes the switch to `hb_string_T` based token values easier later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts using the
hb_string_Tin the interface ofherb_analyze.This is a side effect free refactor, that makes the switch to
hb_string_Tbased token values easier later on.