builder/builder.go (1)

80-98: Consider collecting all cleanup errors rather than returning on first failure.

The current implementation returns immediately if closing the log file fails, which means the RabbitMQ connections won't be closed. For cleanup methods, it's generally better to attempt all cleanup operations and aggregate any errors encountered.

Here's a more robust approach:

 func (b *Builder) Close() error {
+	var errs []error
+
 	// Close log file if it was opened
 	if b.logsFile != nil {
 		if err := b.logsFile.Close(); err != nil {
-			return err
+			errs = append(errs, fmt.Errorf("failed to close log file: %w", err))
 		}
 	}
 
 	// Close RabbitMQ connections
 	if b.rabbitMQConnection != nil {
 		if err := b.rabbitMQChannel.Close(); err != nil {
-			return err
+			errs = append(errs, fmt.Errorf("failed to close RabbitMQ channel: %w", err))
 		}
 		if err := b.rabbitMQConnection.Close(); err != nil {
-			return err
+			errs = append(errs, fmt.Errorf("failed to close RabbitMQ connection: %w", err))
 		}
 	}
-	return nil
+
+	if len(errs) > 0 {
+		return errors.Join(errs...)
+	}
+	return nil
 }

Note: errors.Join() requires Go 1.20+. If using an older version, you could combine the errors manually or use a library.

builder/builder_test.go (2)

56-65: Consider removing redundant test.

TestBuilderClose_NilLogFile is functionally identical to TestBuilderClose_NoLogFile since NewBuilder() already initializes logsFile to nil. Both tests exercise the same code path and nil-safety check.

You could remove this test to reduce duplication, or if you want to keep it for explicit documentation purposes, consider adding a comment explaining why both tests exist.

---

1-65: Consider adding test coverage for concurrent resource cleanup.

The current tests cover log file closure in isolation, but there's no test that verifies both the log file and RabbitMQ connections are closed together. Since Close() handles both types of resources, it would be valuable to test that scenario.

Consider adding a test like:

func TestBuilderClose_LogFileAndRabbitMQ(t *testing.T) {
	// Create a temporary directory for the test
	tmpDir := t.TempDir()
	logFilePath := tmpDir + "/test.log"

	// Create a builder instance
	builder := NewBuilder()

	// Build logger
	loggingConfig := parser.Logging{
		LogsPath: logFilePath,
	}
	err := builder.buildLogger(loggingConfig)
	assert.NoError(t, err)

	// Mock or set up RabbitMQ connections (if feasible in test environment)
	// This would require either mocking or a test RabbitMQ instance

	// Close should clean up both resources
	err = builder.Close()
	assert.NoError(t, err)

	// Verify both resources are closed
	_, err = builder.logsFile.WriteString("test")
	assert.Error(t, err)
}

Note: This may require mocking RabbitMQ connections or setting up a test instance, which could be complex. At minimum, consider testing that Close() doesn't fail when both logsFile and rabbitMQConnection are set.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro