Skip to content

Misc cleanup #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rgoldberg merged 25 commits into from
Oct 15, 2025
Merged

Misc cleanup #1025

rgoldberg merged 25 commits into from
Oct 15, 2025

Conversation

@rgoldberg
Copy link
Member

@rgoldberg rgoldberg commented Oct 15, 2025

Misc cleanup.

Resolve #1022

@rgoldberg
Fix Printer ephemeral printing issue.
806a043 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg rgoldberg added this to the 3.0.0 milestone Oct 15, 2025
@rgoldberg rgoldberg self-assigned this Oct 15, 2025
@rgoldberg rgoldberg requested a review from a team as a code owner October 15, 2025 18:58
@rgoldberg rgoldberg added the 🧹 cleanup Optimization of (not bug fix for) an existing feature label Oct 15, 2025
@rgoldberg
Use actual & expected lets for more informative Swift Testing out…
d030c4b 
…put.

Disable `signout` test.

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Avoid using fileno(UnsafeMutablePointer<FILE>).
f1504b0 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Replace computed literal vars with lets.
c484030 
Move private top-level lets to end of containing file.

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Fix JSON resource typo.
026c299 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Update bug report issue template config render type from console to t…
98d4b52 
…ext.

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Ignore .vscode/ for SwiftLint.
e61153d 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Mimic Xcode indentation in SwiftFormat.
cb3cd27 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Restrict Collections dependency to just OrderedCollections.
ede0dab 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Use default (i.e. debug) build configuration for Scripts/build.
ea8fd11 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Improve InstalledApp sorting.
06a9e32 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Use Optional.map(…) & Optional.flatMap(…) instead of if let/else.
e5bb876 
Use `guard` instead of `if/else`.

Use `if {…return}` instead of `if/else`.

Transpose conditions.

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Use keypaths.
d6675f8 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Improve MASError.jsonParsing(…).
88755a2 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Remove Equatable conformance from MASError.
1bad108 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Throw an error when Notification Center doesn't return a `NSMetadataQ…
def661a 
…uery`.

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Rename ISORegion.swift as Region+ISO.swift.
8b6ecc3 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Type alias Region as String.
6379c65 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Improve ISO 3166-1 alpha-2 region DocC.
2e8aa1a 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Lint Periphery both without & with tests.
cba53c5 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Export MAS_INSTALL_METHOD at beginning of both format & lint.
0479896 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Remove unnecessary SearchResult conformance to Hashable.
c05a144 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Simplify MockAppStoreSearcher.
932958a 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Improve uninstall output & path handling.
a1454a7 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Improve property name.
3bdd678 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 15, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rgoldberg rgoldberg merged commit 3028d52 into mas-cli:main Oct 15, 2025
7 checks passed
@rgoldberg rgoldberg deleted the 1022-cleanup branch October 15, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rgoldberg rgoldberg

Labels

🧹 cleanup Optimization of (not bug fix for) an existing feature

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

Misc cleanup

1 participant

@rgoldberg