Skip to content

Conversation

@TheArcaneBrony
Copy link
Contributor

This PR adds the ability to skip NSFW processing if the sensitivity is set to 0.0.
This saves resources, and makes redactions happen faster, allowing it to be used as a generic "disallow images" protection.

I wonder if a setting to opt out of this behavior should be included, even though one could set the sensitivity to 0.0002 to opt out?

@TheArcaneBrony TheArcaneBrony requested a review from a team as a code owner March 13, 2025 12:03
@TheArcaneBrony TheArcaneBrony changed the title Skip NSFW processing if treshold is 0.0 Skip NSFW classification if treshold is 0.0 Mar 13, 2025
@turt2live
Copy link
Member

I wonder if a setting to opt out of this behavior should be included, even though one could set the sensitivity to 0.0002 to opt out?

should be fine without, I think

@TheArcaneBrony
Copy link
Contributor Author

Rebasing after #585 introduced a merge conflict.

@TheArcaneBrony TheArcaneBrony force-pushed the dev/skip-nsfw-processing branch from 7701485 to b2564d4 Compare March 19, 2025 08:11
@TheArcaneBrony
Copy link
Contributor Author

This should now pass CI in theory - linter is happy.

@TheArcaneBrony
Copy link
Contributor Author

Made a mirror branch to enable the mjolnir.yml workflow locally.
Run available here: https://github.com/TheArcaneBrony/mjolnir/actions/runs/13941928985

Copy link
Contributor

@H-Shay H-Shay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Co-authored-by: Shay <hillerys@element.io>
@TheArcaneBrony
Copy link
Contributor Author

(Do you want me to squash the typo fix?)

@H-Shay H-Shay enabled auto-merge (squash) March 19, 2025 22:12
@H-Shay H-Shay disabled auto-merge March 20, 2025 16:59
@H-Shay H-Shay merged commit 7d558ad into matrix-org:main Mar 20, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants