Skip to content

Log & expose device ID and identity at startup for visibility #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
H-Shay merged 4 commits into from
Jun 18, 2025
Merged

Log & expose device ID and identity at startup for visibility #613

H-Shay merged 4 commits into from
Jun 18, 2025

Conversation

@Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Jun 10, 2025

This is done automatically by the bot sdk.

@Half-Shot Half-Shot requested a review from a team as a code owner June 10, 2025 15:22
@H-Shay
Copy link
Contributor

H-Shay commented Jun 12, 2025

Well the tests appear to be passing, before mx_tester falls over and fails the whole thing:

94 passing (10m)
2025-06-12T23:41:34.2465249Z [2025-06-12T23:41:34Z INFO  mx_tester::exec] run:   3 pending
2025-06-12T23:41:34.2466312Z [2025-06-12T23:41:34Z INFO  mx_tester::exec] run: 
2025-06-12T23:41:34.2587635Z [2025-06-12T23:41:34Z INFO  mx_tester::exec] run: thread '<unnamed>' panicked at /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/napi-2.16.13/src/tokio_runtime.rs:114:47:
2025-06-12T23:41:34.2589545Z [2025-06-12T23:41:34Z INFO  mx_tester::exec] run: called `Option::unwrap()` on a `None` value
2025-06-12T23:41:34.2590764Z [2025-06-12T23:41:34Z INFO  mx_tester::exec] run: note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2025-06-12T23:41:34.2591582Z [2025-06-12T23:41:34Z INFO  mx_tester::exec] run: fatal runtime error: failed to initiate panic, error 5
2025-06-12T23:41:44.5372828Z [2025-06-12T23:41:44Z INFO  mx_tester::exec] run: Aborted (core dumped)
2025-06-12T23:41:44.5484767Z [2025-06-12T23:41:44Z INFO  mx_tester::exec] run: error Command failed with exit code 134.

I'm somewhat inclined to just merge this and not gate it behind figuring out what is up with mx_tester - @turt2live any objections to this plan?

@turt2live
Copy link
Member

turt2live commented Jun 16, 2025

sure, though we'll need to figure out what to do about mxtester: either replace or fix it for modern node versions.

@H-Shay H-Shay merged commit 9f6776a into main Jun 18, 2025
10 of 13 checks passed
@H-Shay H-Shay deleted the hs/bot-sdk-update-0.7.1-element.10 branch June 18, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Half-Shot @H-Shay @turt2live