Follow the guide to enable codebase context checks.

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status:
No Auditing: The new search functions add logic but do not emit any audit logs for critical actions,
which may be acceptable for low-level utilities but cannot be verified from the diff
alone.

func OrderedBinarySearchOffsetByValFactory[T types.OrderedT](vals []T) func(*Vector) []int64 {
	return func(vec *Vector) []int64 {
		var sels []int64
		rows := MustFixedColNoTypeCheck[T](vec)
		if len(rows) == 0 || len(vals) == 0 {
			return sels
		}
		subVals := vals
		if len(vals) >= kMinLenForSubVector {
			minVal := rows[0]
			maxVal := rows[len(rows)-1]
			lowerBound := sort.Search(len(vals), func(i int) bool {
				return minVal <= vals[i]
			})
			upperBound := sort.Search(len(vals), func(i int) bool {
				return maxVal < vals[i]
			})
			subVals = vals[lowerBound:upperBound]
			if len(subVals) == 0 {
				return sels
			}


 ... (clipped 208 lines)

Learn more about managing compliance generic rules or creating your own custom rules

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status:
Input Assumptions: Functions assume sorted inputs and trust vector contents without explicit validation or
bounds checks beyond length checks, which may be acceptable internally but cannot be fully
verified from the diff.

func OrderedBinarySearchOffsetByValFactory[T types.OrderedT](vals []T) func(*Vector) []int64 {
	return func(vec *Vector) []int64 {
		var sels []int64
		rows := MustFixedColNoTypeCheck[T](vec)
		if len(rows) == 0 || len(vals) == 0 {
			return sels
		}
		subVals := vals
		if len(vals) >= kMinLenForSubVector {
			minVal := rows[0]
			maxVal := rows[len(rows)-1]
			lowerBound := sort.Search(len(vals), func(i int) bool {
				return minVal <= vals[i]
			})
			upperBound := sort.Search(len(vals), func(i int) bool {
				return maxVal < vals[i]
			})
			subVals = vals[lowerBound:upperBound]
			if len(subVals) == 0 {
				return sels
			}


 ... (clipped 208 lines)

Learn more about managing compliance generic rules or creating your own custom rules

The PR's code fixes binary search on sorted data, but the linked ticket
describes a problem with filtering on unsorted data. This discrepancy should be
clarified by updating the ticket to match the PR's actual changes for better
maintainability.

Examples:

Solution Walkthrough:

Before:

// PR Code in pkg/container/vector/search.go
// Fixes binary search for duplicate values in *sorted* data.
func OrderedBinarySearchOffsetByValFactory[T types.OrderedT](vals []T) func(*Vector) []int64 {
  // ... logic to find all occurrences of `vals` in a sorted vector
}

// Ticket #13959 Description
// Title: optimize reader to support filer on *unsorted* block
// Description: "t1 is never sorted by the fake key and right now the reader will not apply any input filter"

After:

// PR Code in pkg/container/vector/search.go
// The code is likely correct for its intended purpose and may not need changes.
func OrderedBinarySearchOffsetByValFactory[T types.OrderedT](vals []T) func(*Vector) []int64 {
  // ... logic to find all occurrences of `vals` in a sorted vector
}

// Updated Ticket #13959 Description (or new ticket)
// Title: Fix block filter (EQ, IN) to correctly handle duplicate values in sorted blocks
// Description: "The binary search functions used by the block filter did not correctly return all indices for search values that have duplicates in the data block. This PR fixes the search logic to find all occurrences."

In TestVarlenBinarySearchOffsetByValFactoryEmptyInputs, change the test
assertion from require.Nil to require.Empty to correctly reflect that the
function returns an empty slice, not a nil one.

pkg/container/vector/search_test.go [81-86]

 fn := VarlenBinarySearchOffsetByValFactory(nil)
-require.Nil(t, fn(vec))
+require.Empty(t, fn(vec))
 
 require.NoError(t, AppendBytes(vec, []byte("a"), false, mp))
 fn = VarlenBinarySearchOffsetByValFactory(nil)
-require.Nil(t, fn(vec))
+require.Empty(t, fn(vec))

• Apply / Chat