Making the language meta actually call set_lang. #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, removing unwarranted xml:lang in the template -- it's better to say nothing than to lie.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, removing unwarranted xml:lang in the template -- it's better
to say nothing than to lie.
Without this, the generated e-books will always declare en-us, with whatever is passed in in language as a second. This typically causes bad hyphenation patterns to be used.
As to xml:lang: Let's not claim anything we don't know for a fact. Language autodetection is pretty good these days, so we're probably going to spoil more that we might possibly fix.