Expand ID range to harden brute forcing #71
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
If I see correctly, this will break all existing paste ids? |
Contributor
Author
|
Added backwards compatibility. |
Expand the domain for IDs from 2^32 to 2^64, resulting in keys of length 11 instead of 6. In particular important for one-time-pastes. i64 is used as inner type since sqlite does not support storing u64.
matze
reviewed
Jan 17, 2025
| fn convert_id_from_string() { | ||
| assert!(Id::from_str("abDE+-").is_ok()); | ||
| /* Support ID generated in the old 32-bit format */ | ||
| //assert!(Id::from_str("abDE+-").is_ok()); |
Owner
There was a problem hiding this comment.
Why is this outcommented? Also, please use proper Rust comments, i.e. // instead of /* */.
matze
reviewed
Jan 17, 2025
| s.push(CHAR_TABLE[(self.n & 0x3) as usize]); | ||
|
|
||
| write!(f, "{s}") | ||
| #[allow(clippy::cast_sign_loss)] |
matze
reviewed
Jan 17, 2025
| const CHAR_TABLE: &[u8; 64] = b"abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-+"; | ||
|
|
||
| /// Represents a 32-bit integer either numerically or mapped to a 6 character string. | ||
| pub type Inner = i64; |
Owner
There was a problem hiding this comment.
Stupid question: what's the point of this type alias?
cb5a690 to
6c7c60d
Compare
Owner
|
Thanks for the inspiration, I took some of the ideas for 89b215d and credited this prior contribution of yours. Hope that is okay and that I close this PR as being done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand the value space from 2^32 to 2^64, resulting in keys of length 11 instead of 6.
In particular important for one-time-pastes.
i64 is used as inner type since sqlite does not support storing u64.