test(auto-refresh-token): fix loginOptions in login inactivity test #685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tho-myr
approved these changes
Nov 28, 2025
AdrisGithub
approved these changes
Nov 29, 2025
jarczykkonrad
approved these changes
Dec 3, 2025
jarczykkonrad
left a comment
There was a problem hiding this comment.
Good catch! Looked at this as well
| it('should login if user is inactive and inactivity timeout is set to "login"', async () => { | ||
| service['options'].onInactivityTimeout = 'login'; | ||
| service['options'].logoutOptions = { redirectUri: 'testLoginUri' }; | ||
| service['options'].loginOptions = { redirectUri: 'testLoginUri' }; |
Owner
|
Hi @no-felix, |
mauriciovigolo
approved these changes
Dec 11, 2025
|
@mauriciovigolo When do you think you will release v21? :) |
|
@mauriciovigolo Hi! Sorry, will you release v21 before christmas? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
A unit test in AutoRefreshTokenService's spec incorrectly assigns logoutOptions in the "login" inactivity timeout test, causing an expectation failure because mockKeycloak.login is invoked with undefined.
Issue Number: N/A
What is the new behavior?
Correct the test to set loginOptions: { redirectUri: 'testLoginUri' } for the "login" inactivity timeout case.
The test now verifies that mockKeycloak.login is called with the expected options.
No production code changes.
Does this PR introduce a breaking change?
Other information