-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[UX] Specify redirection labels present when creating a landing page #13490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Specify redirection labels present when creating a landing page #13490
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.x #13490 +/- ##
============================================
+ Coverage 60.57% 60.59% +0.01%
- Complexity 33835 33845 +10
============================================
Files 2231 2232 +1
Lines 101135 101179 +44
============================================
+ Hits 61260 61305 +45
+ Misses 39875 39874 -1 |
|
I think this is missing a bit more info. If a user doesn't know (or look up) the redirection code, it's probably not going to be solved by adding an extra bit like |
|
@LordRembo I'm struggling to change the form structure (adding a link below the field, for example). Do you have a tip about where should I look? Then may I create a separate PR or change this one? |
|
@andersonjeccel I'm also not sure how to extend the form. I can see it's built partly in |
|
@LordRembo Hm, thanks for checking! I'll give it a try next week |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@RCheesley Where do we need to change documentation? I think we can merge this pull request. We can create another later focusing on explaining the different redirection types (but anyone can search on the internet what each means in the meantime). |
kuzmany
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basic users will not understand with or without change. But go
|
I started a discussion on Slack to suggest how to solve this: but it'll be a separate PR |
RCheesley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi folks!
I think this is confusing for the user - (GET) and (HTTP) is just using developer language which we're professing to be moving away from.
I agree that as a better approach, we should write up an article on the Knowledgebase which explains the redirect codes. It would be a useful article in general. For example, from my brief reading a 308 is being favoured for SEO reasons nowadays as being a 'cleaner' redirect.
So I'm not in favour of this PR being merged, instead we should help users understand what the error codes mean and why you might use them.
Description:
This update enriches the redirection options during landing page creation with descriptive labels. It aims to guide users in selecting the appropriate redirect type by explaining the difference between temporary and permanent redirects, and when each should be used. This clarification assists users in making informed decisions, ensuring their landing pages function as intended and enhancing the overall creation process.
Now people can just select the less complicated option to fit 99,99% of their needs.
Steps to test this PR: