[UI] Accordions.less #13940
Merged
[UI] Accordions.less #13940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.x #13940 +/- ##
=========================================
Coverage 62.51% 62.51%
Complexity 34353 34353
=========================================
Files 2260 2260
Lines 102740 102740
=========================================
Hits 64233 64233
Misses 38507 38507 |
Member
|
@andersonjeccel here are some conflicts |
Contributor
Author
|
@escopecz Solved! |
Closed
LordRembo
suggested changes
Aug 1, 2024
Contributor
LordRembo
left a comment
There was a problem hiding this comment.
Some comments for the code added
app/bundles/CoreBundle/Assets/css/app/less/components/accordions.less
Outdated
Show resolved
Hide resolved
app/bundles/CoreBundle/Assets/css/app/less/components/accordions.less
Outdated
Show resolved
Hide resolved
app/bundles/CoreBundle/Assets/css/app/less/components/accordions.less
Outdated
Show resolved
Hide resolved
LordRembo
approved these changes
Aug 1, 2024
Contributor
|
The description of the PR could use a link to a page of where to test it properly (path or url). That's not immediately clear from the video. |
Contributor
Author
|
PRs where you can interact with it: |
Contributor
Author
|
Warning All Tier 1 PRs need only 1 code review and 1 user testing before able to merge. I'll update accordingly. |
Member
|
Just waiting for the tests to pass then I'll get this one merged! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dependency:
This PR adds an accordion component. It's based on the Bootstrap JS logic (that's why there is a .panel in the code), but with unique style.
accordion.mp4
📋 Steps to test this PR:
But PRs where you can interact with it: