[UX] Change contact details logic for not defined items #13929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 6d9515f Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Fri Jun 28 09:45:57 2024 -0300 fixes commit 58ed66b Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Wed Jun 26 12:38:59 2024 -0300 rebase commit d143ede Merge: fd14128 4fb0c5c Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Wed Jun 26 12:37:35 2024 -0300 Merge remote-tracking branch 'upstream/5.x' into ui-notifications commit fd14128 Merge: 86ff64b c8f3818 Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Tue Jun 11 16:43:40 2024 -0300 Merge remote-tracking branch 'upstream/5.x' into ui-notifications commit 86ff64b Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Thu May 23 17:02:16 2024 -0300 style commit 179c312 Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Wed May 22 15:16:59 2024 -0300 removing duplicates commit e6f2b75 Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Tue May 21 14:00:26 2024 -0300 enhanced border calc commit 6cdf195 Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Tue May 21 13:46:39 2024 -0300 reduced max bdr value commit 3c8a340 Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Mon May 20 11:58:54 2024 -0300 sat improv commit f2cab43 Merge: d32df8c a66c8d0 Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Mon May 20 11:41:27 2024 -0300 Merge branch '5.x' into ui-token-based-approach-for-interface-elements-and-colors commit d32df8c Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Mon May 20 11:40:50 2024 -0300 Revert "transparency for borders when on brand bg" This reverts commit a8c4748. commit a8c4748 Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Mon May 20 11:38:23 2024 -0300 transparency for borders when on brand bg commit 65ee89b Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Mon May 20 10:48:48 2024 -0300 fixes for secondary brand color support commit 40a2303 Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Mon May 20 09:40:13 2024 -0300 style fixes commit 74f49e0 Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Mon May 20 09:31:23 2024 -0300 secondary brand color support commit d0e7fec Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Mon May 20 09:17:39 2024 -0300 Responsive typography commit b3d2af4 Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Wed May 15 12:11:49 2024 -0300 darker brand bg on dark theme commit c848335 Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Tue May 14 13:59:35 2024 -0300 fix missing transparency bg colors commit 1675884 Merge: db55686 4883fa0 Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Tue May 14 09:13:00 2024 -0300 Merge branch '5.x' into ui-token-based-approach-for-interface-elements-and-colors commit db55686 Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Tue May 14 08:50:00 2024 -0300 set implementation mode for high contrast + run grunt-compile-less commit d91ba0b Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Fri May 10 17:29:33 2024 -0300 setting the dark theme implementation method commit f80989c Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Fri May 10 15:31:04 2024 -0300 tag to label token names commit 5e3bee9 Merge: ff5a8ed e88cf96 Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Thu May 9 13:44:30 2024 -0300 Merge branch '5.x' into ui-token-based-approach-for-interface-elements-and-colors commit ff5a8ed Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Wed May 8 17:21:07 2024 -0300 improve radius calc commit 42d1c5d Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Wed May 8 17:16:57 2024 -0300 utilities syntax fix commit c7d151b Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Wed May 8 16:58:34 2024 -0300 dark color scheme disabled by default to avoid conflicts commit af02466 Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Wed May 8 15:46:57 2024 -0300 remove duplicated imports commit 7f261c4 Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Wed May 8 13:29:33 2024 -0300 aligning previous tokens commit 4aaa9d9 Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Wed May 8 13:27:24 2024 -0300 grunt compile-less commit e7dbe89 Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Wed May 8 13:18:51 2024 -0300 revert removing 5x duplicated import rules revert Revert "fixing broken darken/lighten" This reverts commit bcf4ac98e07c0c17162a74794a8161d5398c3d7c. commit af355d6 Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Wed May 8 13:13:59 2024 -0300 variables commit 5a97e52 Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Tue May 7 17:17:45 2024 -0300 fixing broken darken/lighten commit f4baec1 Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Tue May 7 16:03:53 2024 -0300 migrating mautic variables into bootstrap commit 23e3b6f Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Tue May 7 15:45:35 2024 -0300 incorporating all bootstrap variables commit 6a16fdf Author: andersonjeccel <116097999+andersonjeccel@users.noreply.github.com> Date: Tue May 7 15:27:32 2024 -0300 tokens
…not-defined-items
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.x #13929 +/- ##
============================================
- Coverage 62.69% 62.69% -0.01%
Complexity 34367 34367
============================================
Files 2260 2260
Lines 102786 102786
============================================
- Hits 64443 64442 -1
- Misses 38343 38344 +1 |
This was referenced Jul 16, 2024
Closed
Merged
Contributor
Author
|
Warning All Tier 1 PRs need only 1 code review and 1 user testing before able to merge. I'll update accordingly. |
…tails-logic-for-not-defined-items
escopecz
requested changes
Aug 26, 2024
app/bundles/LeadBundle/Resources/views/Integration/index.html.twig
Outdated
Show resolved
Hide resolved
app/bundles/LeadBundle/Resources/views/Lead/lead_stats.html.twig
Outdated
Show resolved
Hide resolved
Co-authored-by: John Linhart <jan@linhart.email>
…twig Co-authored-by: John Linhart <jan@linhart.email>
Co-authored-by: John Linhart <jan@linhart.email>
Co-authored-by: John Linhart <jan@linhart.email>
https://github.com/andersonjeccel/mautic into ux-change-contact-details-logic-for-not-defined-items
https://github.com/andersonjeccel/mautic into ux-change-contact-details-logic-for-not-defined-items
…tails-logic-for-not-defined-items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dependency:
This PR ensures that users will have proper system feedback about features related to contact details.
Before, tabs were hidden and as a marketer, I often got confused with functionalities disappearing without knowing how to enable them.
Now, all features have a proper message when no data is available and Mautic feels more feature-rich.
I also added guidelines to the documentation, so devs can follow them when creating new features and also helping people to review PRs with clarity about how things need to be for approval.
📋 Steps to test this PR: