[UX] Absurdly aggressive method to ensure tooltips always work anywhere #14043
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.x #14043 +/- ##
============================================
- Coverage 62.51% 62.51% -0.01%
Complexity 34345 34345
============================================
Files 2258 2258
Lines 102714 102714
============================================
- Hits 64211 64210 -1
- Misses 38503 38504 +1 |
Esthertests
left a comment
There was a problem hiding this comment.
while testing i could see some html tags within the text, can these be removed
|
@Esthertests Yep (in another PR, it's a bug not related to this one), thanks for testing! |
Bastian2718
left a comment
There was a problem hiding this comment.
Irritating Questionmark, shows nothing to me.
|
Warning All Tier 1 PRs need only 1 code review and 1 user testing before able to merge. I'll update accordingly. |
|
Testing passed based on Esther's test |
LordRembo
left a comment
There was a problem hiding this comment.
Added comment on the JS code about the formatting and location
| }); | ||
| } | ||
|
|
||
| // Absurdly aggressive method to ensure tooltips always work anywhere |
There was a problem hiding this comment.
A bit of a similar issue as I described in #13948 : the code looks fine, but it shouldn't be in this location.
I'm fine with tooltips code existing in core.js if there's no better place for it, but you need to follow the style and formatting of the rest of the file:
- functions should be in the
Mauticnamespace (nesting starts around line 154, or you can prefix it like happens in other files) - variables should be prefixed with
MauticVars(as you can see above that)
There was a problem hiding this comment.
Oh, got it
It’ll be fixed asap
I’ll also take notes for future implementations
Thanks for reviewing 🙏🏻
Description
This PR really ensures that tooltips will work FOREVER, anywhere you place it, using MutationObserver.
📋 Steps to test this PR: