[UX] New default dashboard templates #14013
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.x #14013 +/- ##
=========================================
Coverage 62.99% 62.99%
Complexity 34433 34433
=========================================
Files 2266 2266
Lines 103019 103019
=========================================
Hits 64893 64893
Misses 38126 38126 |
There was a problem hiding this comment.
@andersonjeccel I just tested and found two things:
-
Saving one of the newly added Templates doesnt actually change the dashboard. The page reloads but the old widgets stay and no new widget is being added.
I would change the names to include spacing instead of "_" and also add "Example" to the titles.
|
@oltmanns-leuchtfeuer Good catch, thanks for testing! |
|
Warning All Tier 1 PRs need only 1 code review and 1 user testing before able to merge. I'll update accordingly. |
LordRembo
left a comment
There was a problem hiding this comment.
The code looks fine, it's just valid json.
There was a problem hiding this comment.
@andersonjeccel test failed. Kindly review the feedback below.
- Forms and Assets work as expected, with 14 widgets on display on the dashboard when previewed and saved, showing contact info.
- Landing pages test failed, with 18 widgets on display when previewed and saved, showing page insights. It was found that the "Downloads in time" widget was duplicated (appeared twice as the 1st widget and 7th widget from top to bottom) which accounts for the 18 widgets displayed as opposed 17 widgets expected.
Check the attached images below for more clarity.
|
First of all, thanks for reviewing! Some of the widgets had the same name, but their configuration was a bit different (for example, showing only new contacts that have email instead of contacts that we have IP address) To improve that specific template, I removed some of the widgets and reordered to maybe become easier to understand I'll appreciate if you could review again :) Have a nice day! |
There was a problem hiding this comment.
Great work! @andersonjeccel
I've tested the revised implementation and test passed. Here's a quick summary below;
- Forms and Assets displayed 14 widgets, previewed and saved successfully.
- Landing pages displayed 11 widgets, previewed and saved successfully.
- Latest data refresh info, Edit, and Remove are functional on the dashboard.
Thank you for your contribution. Cheers!
Description
This PR adds 2 new dashboard templates:
using related widgets in each.
The first aims to show submissions, related downloaded assets and identified contacts.
The second aims to show page visits, all contacts created (including anonymous) and a bit of assets.
📋 Steps to test this PR: