[UXUI-170] Defining code mode as last option in themes #14983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 7.x #14983 +/- ##
=========================================
Coverage 66.25% 66.25%
Complexity 35144 35144
=========================================
Files 2314 2314
Lines 141585 141585
=========================================
Hits 93805 93805
Misses 47780 47780 🚀 New features to boost your workflow:
|
laurielim
approved these changes
May 7, 2025
Member
laurielim
left a comment
There was a problem hiding this comment.
Reviewed code and tested. Works as described, code mode is at the end of the list of themes
escopecz
reviewed
May 20, 2025
Member
escopecz
left a comment
There was a problem hiding this comment.
I'm not a fan of this, but if this gets another approval I'll merge it.
kingsedem
approved these changes
May 23, 2025
kingsedem
left a comment
There was a problem hiding this comment.
I have tested this PR and it works as expected.
Before
After
escopecz
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves Code mode as last option when picking Email themes to make UI-editable themes higher in priority as they make Mautic's adoption easier for beginners
📋 Steps to test this PR: