-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Fix email graph ignored read failed #15519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix email graph ignored read failed #15519
Conversation
kuzmany
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we use the same fix in our branch. Good to go
|
matbcvo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested the PR, works as expected. Thanks! 👍
|
@all-contributors please add @naoya-kawakatsu for code |
|
I've put up a pull request to add @naoya-kawakatsu! 🎉 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 7.x #15519 +/- ##
============================================
- Coverage 67.91% 67.91% -0.01%
Complexity 36386 36386
============================================
Files 2366 2366
Lines 146163 146164 +1
============================================
- Hits 99266 99265 -1
- Misses 46897 46899 +2
🚀 New features to boost your workflow:
|
Description
Currently, in the email report, "Ignored / Read / Failed emails" does not provide accurate information because it always reflects only the information of the email_stats1 record.

The query executed in StatRepository's getIgnoredReadFailed is as follows:
The query itself is not a big problem. However, the problem is that because of the "GROUP BY es.id;" statement, there is only one piece of email_stats information per row, but getIgnoredReadFailed only uses that one row of data.
As a result, the pie chart always only provides information for one email.
This PR solves the problem by removing the group by statement from the query, allowing getIgnoredReadFailed to execute the desired query.
📋 Steps to test this PR: