Skip to content

Updating Rector and PHPSTAN #15732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
escopecz wants to merge 3 commits into
base: 7.x
Choose a base branch
from
Open

Updating Rector and PHPSTAN #15732

escopecz wants to merge 3 commits into from

Conversation

@escopecz
Copy link
Member

@escopecz escopecz commented Dec 12, 2025

Q A
Bug fix? (use the a.b branch) ❌
New feature/enhancement? (use the a.x branch) ✔️
Deprecations? ❌
BC breaks? (use the c.x branch) ❌
Automated tests included? Rector itself
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

Rector has newer format how to configure itself. It is shorter and easier to read. Here is a short example in the Rector readme.

The rules for test files are already using this newer format. This PR is updating the other 2 Rector config files to follow the same more modern format.

It has no effect on functionality of Rector and no change for production code.

📋 Steps to test this PR:

  1. Just check that CI is green. There was no production code changed.

@escopecz escopecz added code-review-needed PR's that require a code review before merging enhancement Any improvement to an existing feature or functionality refactoring The change does not change behavior but improves the code developer-experience Anything related to developer experience labels Dec 12, 2025
@escopecz escopecz added this to the 7.1.0 milestone Dec 12, 2025
@codecov
Copy link

codecov bot commented Dec 15, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 90.24390% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.67%. Comparing base (3c5dc8b) to head (a326f50).
⚠️ Report is 18 commits behind head on 7.x.

Files with missing lines Patch % Lines
...ntListener/CampaignEventImportExportSubscriber.php 0.00% 1 Missing ⚠️
...les/CoreBundle/EventListener/ImportExportTrait.php 0.00% 1 Missing ⚠️
...dles/CoreBundle/IpLookup/AbstractMaxmindLookup.php 0.00% 1 Missing ⚠️
...ContentBundle/EventListener/CampaignSubscriber.php 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                7.x   #15732      +/-   ##
============================================
+ Coverage     68.65%   68.67%   +0.01%     
+ Complexity    36930    36928       -2     
============================================
  Files          2399     2399              
  Lines        138890   138871      -19     
============================================
+ Hits          95361    95367       +6     
+ Misses        43529    43504      -25
Files with missing lines Coverage Δ
app/bundles/ApiBundle/Entity/oAuth2/Client.php 79.51% <ø> (ø)
app/bundles/AssetBundle/Entity/Download.php 85.71% <ø> (ø)
app/bundles/CampaignBundle/Entity/Event.php 93.93% <ø> (ø)
...gnBundle/EventListener/CampaignEventSubscriber.php 97.22% <100.00%> (ø)
...ampaignBundle/Executioner/ScheduledExecutioner.php 95.05% <100.00%> (ø)
...p/bundles/CoreBundle/Controller/AjaxController.php 45.45% <100.00%> (ø)
...undle/EventListener/MigrationCommandSubscriber.php 100.00% <100.00%> (ø)
...namicContentBundle/Helper/DynamicContentHelper.php 72.16% <100.00%> (ø)
app/bundles/EmailBundle/Entity/StatDevice.php 65.11% <ø> (ø)
app/bundles/FormBundle/Entity/Field.php 93.50% <ø> (ø)
... and 25 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 15, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@escopecz escopecz changed the title New format for Rector config files Updating Rector and PHPSTAN Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

code-review-needed PR's that require a code review before merging developer-experience Anything related to developer experience enhancement Any improvement to an existing feature or functionality refactoring The change does not change behavior but improves the code

Projects

None yet

Milestone

7.1.0

Development

Successfully merging this pull request may close these issues.

1 participant

@escopecz