Skip to content

Conversation

@EmmaSimon
Copy link
Contributor

Summary

Ticket:  | Notifications | Edit favorites flow

Update the edit favorites page to open the save favorite page and display a notification icon if notifications are enabled. Also add a low effort notifications toggle to test notifications icon. This does not include swipe to delete.

Simulator Screenshot - iPhone 16 - 2025-11-25 at 14 35 19

iOS

  • If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?
    - [ ] Add temporary machine translations, marked "Needs Review"

Testing

Added new tests, though since they rely on deeply nested feature flags, I could only test the leaf view

Also add a low effort notifications toggle to test notifications icon.
This does not include swipe to delete.
@EmmaSimon EmmaSimon requested a review from a team as a code owner November 25, 2025 19:37
@EmmaSimon EmmaSimon force-pushed the es-edit-favorites-updates branch from cd5ef36 to 2482480 Compare November 25, 2025 20:17
@EmmaSimon EmmaSimon force-pushed the es-edit-favorites-updates branch from 2482480 to 62df40b Compare November 25, 2025 20:55
@EmmaSimon EmmaSimon enabled auto-merge November 25, 2025 20:58
@EmmaSimon EmmaSimon added this pull request to the merge queue Nov 25, 2025
Merged via the queue into main with commit dd72a93 Nov 25, 2025
11 checks passed
@EmmaSimon EmmaSimon deleted the es-edit-favorites-updates branch November 25, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants