feat: Clear stale favorites on app launch #1467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonTR
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Reasonably handle favorite stops removed from route
Handle cases where routes, stops, or directions are removed from GTFS but are still saved in favorites. This will not remove the favorites if an FCM token is not set, so that if there's a delay on app launch with setting the token, the favorites are not removed without updating the backend to remove the notifications. Since all real devices should always have a token, hopefully this won't lead to cases where a token never gets set and stale favorites are never removed, but I couldn't think of a better way to deal with that situation.
Testing
Added unit tests for the new VM call