feat(GlobalResponse.getRotuesForPicker): Filter out unlisted routes #1153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmaSimon
approved these changes
Jul 18, 2025
| routes.values.filter { it.type == RouteType.COMMUTER_RAIL && it.isListedRoute } | ||
| is RoutePickerPath.Ferry -> | ||
| routes.values.filter { it.type == RouteType.FERRY && it.isListedRoute } | ||
| } |
Contributor
There was a problem hiding this comment.
nitpick: I know it means an unnecessary loop through the list, but it might be a bit cleaner and less error prone to filter out the unlisted routes after the mode filter as a separate call, rather than adding it to each of the existing ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: 🤖 | Favorites | Fix: Non-listed routes displayed
What is this PR for?
Filters out unlisted routes from the list of all routes in the add favorites flow.
iOS
android
withContext(Dispatchers.Default)where possible (ideally in shared code)Testing
What testing have you done?