Skip to content

fix: misc. route-specific edge case favorites QA #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KaylaBrady merged 5 commits into from
Jul 21, 2025
Merged

fix: misc. route-specific edge case favorites QA #1156

KaylaBrady merged 5 commits into from
Jul 21, 2025

Conversation

@KaylaBrady
Copy link
Collaborator

@KaylaBrady KaylaBrady commented Jul 21, 2025

Summary

Ticket: 🤖 | Favorites | Fix: route-specific findings

What is this PR for?
This PR addresses 3 small QA findings for edge case routes

  1. Disclaimer when trying to add a stop with no service
  2. Android only - trash icon missing in edit favorites when long headsign
  3. All stops collapsed as less common when no typical pattern

iOS

  • If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?
    • Add temporary machine translations, marked "Needs Review"

android

  • All user-facing strings added to strings resource in alphabetical order
  • Expensive calculations are run in withContext(Dispatchers.Default) where possible (ideally in shared code)

Testing

What testing have you done?

Case Android iOS
1. Drop-of only (also unit tested) Forced case for iOS at park st since add favorites not implemented yet for SL image IMG_0337
2. Android trash icon image N/A
3. no typical patterns (also unit tested) image IMG_0338

@KaylaBrady KaylaBrady requested a review from a team as a code owner July 21, 2025 18:41
@KaylaBrady KaylaBrady requested a review from EmmaSimon July 21, 2025 18:41
KaylaBrady
KaylaBrady commented Jul 21, 2025
View reviewed changes
androidApp/src/main/java/com/mbta/tid/mbta_app/android/routeDetails/RouteStopListView.kt
horizontalAlignment = Alignment.Start,
scrollEnabled = !loading,
) {
val hasTypicalSegment = stopList.segments.any { it.isTypical }
Copy link
Collaborator Author

@KaylaBrady KaylaBrady Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in slack, this is a simplified approach to solving this problem which requires the assumption that when there is no pattern of typicality 1, then all patterns are of the same typicality.

@KaylaBrady KaylaBrady added this pull request to the merge queue Jul 21, 2025
Merged via the queue into main with commit 7a987aa Jul 21, 2025
7 checks passed
@KaylaBrady KaylaBrady deleted the kb-route-specific-findings branch July 21, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmmaSimon EmmaSimon EmmaSimon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KaylaBrady @EmmaSimon