feat(iOS): non-subway route picker #1163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8cbeff9 to
9f016ed
Compare
| RoutePickerPath.Bus(), | ||
| RoutePickerPath.Silver(), | ||
| RoutePickerPath.CommuterRail(), | ||
| RoutePickerPath.Ferry(), |
Member
There was a problem hiding this comment.
For Kotlin objects I think it’s better to use .shared than (), although I’d expect () to return the sole instance anyway.
| ] | ||
|
|
||
| private var headerTitle: String { | ||
| switch path { |
Member
There was a problem hiding this comment.
If you use SKIE’s onEnum(of: path) then you can just have case .root etc with no unnecessary default.
Contributor
Author
There was a problem hiding this comment.
Oh nice! Thank you
boringcactus
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: | Favorites | Add stops flow - non-subway list
Adds non-subway functionality to route picker view. Also did a few small design fixes.
Testing
Added/ported tests for new route picker functionality