fix: Order nearby stops after filtering #1179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boringcactus
approved these changes
Jul 28, 2025
Member
boringcactus
left a comment
There was a problem hiding this comment.
Glad this fix turned out simple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Investigate: nearby stop sort order
The list of stop IDs going into
filterStopsWithRedundantPatternswas sorted by distance, but the list coming out gets pieced together from a set and map, which lost the distance context. In most cases this was fine, because another distance sort happens during route card data creation, but in cases like the GL at Hynes, there are multiple bus routes which have a nearest stop at Kenmore. Since the GL Kenmore platforms were also within the radius and the bus routes patterns were being processed first, the GL Kenmore platforms were being returned above Hynes, then the route card processing would assume that was the closest GL stop and filter out Hynes.This change simply sorts the filtered stop IDs based on the original stop ID list.
iOS
- [ ] If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?- [ ] Add temporary machine translations, marked "Needs Review"android
- [ ] All user-facing strings added to strings resource in alphabetical order- [ ] Expensive calculations are run inwithContext(Dispatchers.Default)where possible (ideally in shared code)Testing
Verified that Hynes now shows up properly when it's the nearest GL stop