feat: eastern time all the time #1182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # androidApp/src/main/java/com/mbta/tid/mbta_app/android/util/TripInstantDisplayExtension.kt
EmmaSimon
approved these changes
Jul 29, 2025
Contributor
EmmaSimon
left a comment
There was a problem hiding this comment.
Yeah this is a lot, thanks for tracking all of the usages down 😵 I appreciate that stuff like initializers and addition/subtraction are a bit more streamlined and consistent across platforms now.
| val propertyName = SemanticsProperties.ContentDescription.name | ||
| return SemanticsMatcher("$propertyName matches $regex") { | ||
| it.config.getOrNull(SemanticsProperties.ContentDescription)?.any { item -> | ||
| item.matches(regex) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Eastern time, all the time
I’m sorry I keep making these massive PRs.
I probably could’ve just centralized the formatting to use Eastern Time without also introducing the custom
EasternTimeInstant, but I think the customEasternTimeInstantis clearer and also simpler to create with a specific value.iOS
[ ] If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?[ ] Add temporary machine translations, marked "Needs Review"android
[ ] All user-facing strings added to strings resource in alphabetical order[ ] Expensive calculations are run inwithContext(Dispatchers.Default)where possible (ideally in shared code)Testing
Checked on both iOS and Android that things that are about to happen show two hours later. Updated unit tests to assert that the correct time is shown.