Skip to content

Conversation

@KaylaBrady
Copy link
Collaborator

Summary

Ticket:  🤖 | Favorites | Toast on first time only

What is this PR for?
iOS version of #1189. Shows a toast the first time a user lands on favorites after seeing the promo if they already had pinned routes. Love how simple shared VMs makes this!

iOS

  • If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?
    • Add temporary machine translations, marked "Needs Review"

android

  • All user-facing strings added to strings resource in alphabetical order
  • Expensive calculations are run in withContext(Dispatchers.Default) where possible (ideally in shared code)

Testing

What testing have you done?

  • Added unit test
  • Ran locally, confirmed toast popped & cleared as expected
ScreenRecording_07-31-2025.15-10-22_1.MP4

@KaylaBrady KaylaBrady requested a review from a team as a code owner July 31, 2025 19:37
@KaylaBrady KaylaBrady requested review from EmmaSimon and removed request for a team July 31, 2025 19:37
Base automatically changed from kb-favorites-toast to main July 31, 2025 20:07
@KaylaBrady KaylaBrady force-pushed the kb-ios-favorites-toast branch from 3e765cc to 98f4f4b Compare July 31, 2025 20:46
@KaylaBrady KaylaBrady added this pull request to the merge queue Aug 1, 2025
Merged via the queue into main with commit 99ba786 Aug 1, 2025
11 checks passed
@KaylaBrady KaylaBrady deleted the kb-ios-favorites-toast branch August 1, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants